Migrate from Java 17 to Java 21#261
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the build/runtime target from Java 17 to Java 21. The Spring Boot parent (
3.3.3) already supports 21, so no dependency changes were needed.pom.xml<java.version>17</java.version>→21maven-compiler-plugin: it had a stale<source>1.8</source>/<target>1.8</target>(and a hardcoded<version>3.8.0</version>). Both the explicit source/target and the version are now removed so the plugin inherits the version from the Spring Boot parent and the release fromjava.version(compiler now runs withrelease 21).Dockerfilemaven:3.8.3-openjdk-17→maven:3.9-eclipse-temurin-21openjdk:17-alpine→eclipse-temurin:21-jre-alpine(theopenjdkimages are deprecated and have no21-alpinetag)Verification
./mvnw clean installwith JDK 21: BUILD SUCCESS, compiled withrelease 21,Tests run: 1, Failures: 0, Errors: 0(against a live MySQL).docker build .: both stages build successfully on the new base images.Kubernetes manifests (
kubernetes/) and Helm charts (helm/bankapp/) reference the container image, not a Java version, and contain no hardcoded JDK base-image tags — left unchanged.Link to Devin session: https://app.devin.ai/sessions/ca7656e2aa9740fabbff35d379ec17ed
Requested by: @joao-cognition
Devin Review